-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecation Updates for SceneTransforms Methods #12156
Conversation
Thank you for the pull request, @jvrjsanchez! ✅ We can confirm we have a CLA on file for you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks @jvrjsanchez! I have a few comments on the code that should be addressed before we can merge this.
@@ -337,7 +337,7 @@ SceneTransforms.worldToDrawingBufferCoordinates = function ( | |||
* console.log(Cesium.SceneTransforms.wgs84ToWindowCoordinates(scene, position)); | |||
* }, Cesium.ScreenSpaceEventType.MOUSE_MOVE); | |||
*/ | |||
SceneTransforms.wgs84ToDrawingBufferCoordinates = function ( | |||
SceneTransforms.worldToDrawingBufferCoordinates = function ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe SceneTransforms.worldToWindowCoordinates
and SceneTransforms.worldToDrawingBufferCoordinates
already have been defined. Instead, let's just remove the SceneTransforms.wgs84ToWindowCoordinates
and SceneTransforms.wgs84ToDrawingBufferCoordinates
.
merging to place back deprecation warnings so all tests can pass
@jvrjsanchez Our monthly release happens on Tuesday and this needs to make it into that. In the interest of time because we have a long weekend I made some final touches on this to get it over the finish line. Thanks for your work on the PR. |
Thanks all! |
Description
This pull request addresses the deprecation of certain methods within the
SceneTransforms
module. Specifically, the methodswgs84ToDrawingBufferCoordinates
andwgs84ToWindowCoordinates
are being deprecated and will be removed in future versions. This update ensures that our codebase aligns with the latest changes and improves future maintainability.wgs84ToDrawingBufferCoordinates
toworldToDrawingBufferCoordinates
.wgs84ToWindowCoordinates
toworldToWindowCoordinates
.Issue number and link
fixes #12059
Testing plan
gulpfile.js
to execute them.SceneTransforms
pass successfully in different viewing modes (3D, ColumbusView, 2D) and frustum configurations.Author checklist
CONTRIBUTORS.md
CHANGES.md
with a short summary of my change