Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable MSAA by default #12158

Merged
merged 2 commits into from
Aug 27, 2024
Merged

Enable MSAA by default #12158

merged 2 commits into from
Aug 27, 2024

Conversation

jjspace
Copy link
Contributor

@jjspace jjspace commented Aug 27, 2024

Description

As part of updating our visual quality settings we're enabling MSAA by default with 4 samples. This decently improves the way things look in the viewer and doesn't seem to have a significant impact on framerate. MSAA can still be disabled by setting scene.msaaSamples = 1.

I also removed the setting in any sandcastles that were previously setting msaaSamples = 4 as it's no longer needed.

Issue number and link

Part of #12126

Testing plan

  • Create a new Viewer or CesiumWidget and check the value of msaaSamples, it should be 4;
  • Options passed to constructors should still override the default
  • Check that tests pass
  • Do a pass on any existing sandcastles that are already on the heavier side and make sure the framerate is still ok.

Author checklist

  • I have submitted a Contributor License Agreement
  • I have added my name to CONTRIBUTORS.md
  • I have updated CHANGES.md with a short summary of my change
  • I have added or updated unit tests to ensure consistent code coverage
  • I have updated the inline documentation, and included code examples where relevant
  • I have performed a self-review of my code

@jjspace jjspace requested a review from ggetz August 27, 2024 17:14
Copy link

Thank you for the pull request, @jjspace!

✅ We can confirm we have a CLA on file for you.

@ggetz
Copy link
Contributor

ggetz commented Aug 27, 2024

Awesome! My eyes thank you @jjspace.

@ggetz ggetz merged commit 088c4a2 into main Aug 27, 2024
9 checks passed
@ggetz ggetz deleted the msaa-default-on branch August 27, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants