Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove redundant param for writeTextToCanvas #12376

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ibreathebsb
Copy link

@ibreathebsb ibreathebsb commented Dec 17, 2024

Description

This pull request removes redundant parameter textBaseline which is not used in writeTextToCanvas

Author checklist

  • I have submitted a Contributor License Agreement
  • I have added my name to CONTRIBUTORS.md
  • I have updated CHANGES.md with a short summary of my change (no need acutally)
  • I have added or updated unit tests to ensure consistent code coverage
  • I have updated the inline documentation, and included code examples where relevant
  • I have performed a self-review of my code

Copy link

Thank you for the pull request, @ibreathebsb!

✅ We can confirm we have a CLA on file for you.

@javagl
Copy link
Contributor

javagl commented Dec 18, 2024

For me, it looks like this can indeed safely be removed.

There are some broader issues with that function, though - just as cross-references: #9767 , #11747 , ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants