Add support for pattern properties #67
Open
+448
−142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Convert the patterns to actual RegExp objects and then render them as such. This is especially useful for the perfectly valid empty pattern, which otherwise would not appear. Add a function, `propertySpecs`, which returns specs for handling both properties and patternProperties, and then iterate over them both to produce both the summary table and the more detailed info. Right now it creates a separate table for patter properties, but it might be worth considering a single table, since the rendering of the regex makes it pretty clear which is which. Add tests for pattern properties, too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert the patterns to actual RegExp objects and then render them as such. This is especially useful for the perfectly valid empty pattern, which otherwise would not appear.
Add a function,
propertySpecs, which returns specs for handling both properties and patternProperties, and then iterate over them both to produce both the summary table and the more detailed info. Right now it creates a separate table for patter properties, but it might be worth considering a single table, since the rendering of the regex makes it pretty clear which is which.Add tests for pattern properties, too.
I suggest hiding whitespace changes in the diff view, as most of the changes to
lib/generateMarkdown.jsare indentation.