Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not stringify headers for logging #61

Merged
merged 1 commit into from
Nov 12, 2023

Commits on Nov 11, 2023

  1. fix: do not stringify headers for logging

    The frame headers are passed through the `stringifyHeader` for trace
    logging if a logger exists.  Unfortunately a logger is set by default
    so this always occurs.
    
    If we need to log these things as a string, checking that the logger
    is enabled is one option:
    
    ```js
    if (this.log.enabled) {
      // do expensive logging operation
    }
    ```
    
    Another is adding a custom formatter to the log class, or just having
    the header object appear in the console.
    achingbrain committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    693d0dd View commit details
    Browse the repository at this point in the history