-
-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: move validator status type and util to @lodestar/types #7140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nflaig
commented
Oct 8, 2024
| "exited_slashed" | ||
| "withdrawal_possible" | ||
| "withdrawal_done"; | ||
export type {ValidatorStatus}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
re-export for backward compatibility
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #7140 +/- ##
============================================
+ Coverage 49.16% 49.19% +0.03%
============================================
Files 596 597 +1
Lines 39701 39725 +24
Branches 2069 2073 +4
============================================
+ Hits 19518 19542 +24
- Misses 20141 20142 +1
+ Partials 42 41 -1 |
wemeetagain
approved these changes
Oct 8, 2024
Performance Report✔️ no performance regression detected Full benchmark results
|
ensi321
pushed a commit
that referenced
this pull request
Oct 10, 2024
philknows
pushed a commit
that referenced
this pull request
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This change allows other devs to reuse
getValidatorStatus
as it is currently not exported from beacon-node package and most users don't want this heavy package as part of their dependency tree.There is also ongoing work to have a ssz api to return validators ethereum/beacon-APIs#449 but this means it won't include the status directly in the response and it needs to be reconstructed on the client side. Moving this function now makes later implementation of new api simpler.
Description
Move validator status type and util to
@lodestar/types