-
-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: parsing ExecutionRequests from EL #7314
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## devnet-5 #7314 +/- ##
============================================
+ Coverage 48.50% 48.61% +0.11%
============================================
Files 600 603 +3
Lines 40150 40449 +299
Branches 2058 2065 +7
============================================
+ Hits 19475 19666 +191
- Misses 20637 20745 +108
Partials 38 38 |
we should have unit tests for the extract and parse of execution requests |
could add those later, would be good to get all PRs merged to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - can address #7317 later, will collect some "real world" test data using Kurtosis using an EL that has implemented the changes arleady
0x
2) extract the first 2 character of the remaining hex string for request type.