Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: parsing ExecutionRequests from EL #7314

Merged
merged 3 commits into from
Dec 19, 2024
Merged

Conversation

ensi321
Copy link
Contributor

@ensi321 ensi321 commented Dec 18, 2024

  • Move DEPOSIT_REQUEST_TYPE, WITHDRAWAL_REQUEST_TYPE and CONSOLIDATION_REQUEST_TYPE spec constants
  • Previous PR feat: exclude empty requests in execution requests list #7196 incorrectly extracts request type from ExecutionRequestsRpc. This PR fixes it by 1) stripping out 0x 2) extract the first 2 character of the remaining hex string for request type.

@ensi321 ensi321 requested a review from a team as a code owner December 18, 2024 23:48
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.61%. Comparing base (b5fb76c) to head (f60836e).
Report is 31 commits behind head on devnet-5.

Additional details and impacted files
@@             Coverage Diff              @@
##           devnet-5    #7314      +/-   ##
============================================
+ Coverage     48.50%   48.61%   +0.11%     
============================================
  Files           600      603       +3     
  Lines         40150    40449     +299     
  Branches       2058     2065       +7     
============================================
+ Hits          19475    19666     +191     
- Misses        20637    20745     +108     
  Partials         38       38              

@ensi321 ensi321 changed the title fix: fix: parsing ExecutionRequests from EL Dec 19, 2024
@twoeths
Copy link
Contributor

twoeths commented Dec 19, 2024

we should have unit tests for the extract and parse of execution requests

@nflaig
Copy link
Member

nflaig commented Dec 19, 2024

we should have unit tests for the extract and parse of execution requests

could add those later, would be good to get all PRs merged to devnet-5 branch to get an image build to run on kurtosis

Copy link
Member

@nflaig nflaig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - can address #7317 later, will collect some "real world" test data using Kurtosis using an EL that has implemented the changes arleady

@nflaig nflaig merged commit 4b8de08 into devnet-5 Dec 19, 2024
14 of 18 checks passed
@nflaig nflaig deleted the nc/fix-execution-requests branch December 19, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants