This repository has been archived by the owner on Oct 25, 2022. It is now read-only.
Integrate mDNS passive discovery #145
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #145 +/- ##
==========================================
- Coverage 85.11% 83.71% -1.40%
==========================================
Files 84 85 +1
Lines 3312 3396 +84
==========================================
+ Hits 2819 2843 +24
- Misses 493 553 +60
Continue to review full report at Codecov.
|
- feat: impl Event process for Gossipsub. - feat: impl Event process for Identify. - feat: impl Event process for ping. - feat: struct NetworkBehaviour for Event process.
|
Branch is getting pretty stale and with networking not on our immediate roadmap I think it will be easier to re-implement when we need it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
For M5 - implement mDNS discovery #134 currently only have
Reference issue to close (if applicable)
Closes #134
Other information and links