Connect on Initialize Fix #1158
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auto-assign
bot
requested review from
creeppak,
juans-chainsafe,
kantagara and
sneakzttv
sneakzttv
approved these changes
Sep 22, 2024
sneakzttv
added
the
ready-to-merge
…inSafe/web3.unity into rob/connec-on-initialize-fix
kantagara
reviewed
Sep 23, 2024
Packages/io.chainsafe.web3-unity.web3auth/Runtime/Web3AuthProvider.cs
Outdated
Show resolved
Hide resolved
kantagara
approved these changes
Sep 23, 2024
good call, I've updated the description of the PR |
rob1997
added
ready-to-merge
juans-chainsafe
approved these changes
Sep 23, 2024
|
Emm this was merged as part of #1154 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were issues in async execution order for web3auth in async plus some unhandled errors/exceptions
Bug was that connect would get stuck while trying to restore web3auth session