Skip to content

Commit

Permalink
Fix Android.mk
Browse files Browse the repository at this point in the history
  • Loading branch information
@ChainsDD
ChainsDD committed Jun 15, 2011
1 parent 4b31539 commit 9b15727
Showing 1 changed file with 7 additions and 2 deletions.
9 changes: 7 additions & 2 deletions Android.mk
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,13 @@ LOCAL_SRC_FILES := su.c activity.cpp


LOCAL_C_INCLUDES += external/sqlite/dist
LOCAL_SHARED_LIBRARIES := liblog libsqlite libandroid_runtime

LOCAL_SHARED_LIBRARIES := \
liblog \
libsqlite \
libcutils \
libbinder \
libutils
LOCAL_MODULE_PATH := $(TARGET_OUT_OPTIONAL_EXECUTABLES)
LOCAL_MODULE_TAGS := eng,debug

include $(BUILD_EXECUTABLE)

4 comments on commit 9b15727

@Woodyman
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey man had a quick question before this commit the binary built fine into ROMs, but since this commit it no longer has been building the binary and putting it in system/xbin, I can build it manually if i cd to the system/extras/su directory and run the 'mm' command, but doesn't build automatically anymore, wondering if its the tags because this shows up in my output..

build/core/base_rules.mk:69: unusual tags eng,debug on su at system/extras/su

building froyo for sholes

@Woodyman
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested several different ways to get it to build into the ROM like it used to and the only thing that does it is when I remove the 'LOCAL_MODULE_TAGS' line from the android.mk file

@ChainsDD
Copy link
Owner Author

@ChainsDD ChainsDD commented on 9b15727 Jul 6, 2011 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Woodyman
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is the tags, I don't build CM, but I know it doesn't build in on froyo ROMs, I just always preferred using your straight source rather than just linking to the binary from CM or someone else, that was why I cam to ask you.

is there anyway you could remove the local module tags line from source?

thanks for the reply.

Please sign in to comment.