Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: validate pairs of secrets #210

Merged
merged 22 commits into from
Feb 21, 2024
Merged

Conversation

baruchiro
Copy link
Contributor

@baruchiro baruchiro commented Feb 19, 2024

After adding the simple validation process on #206, I'm now adding a validation process for cases where both access key and secret key are needed together.

For these cases, the engine will collect those secrets and after the scan is finished, it will validate all the pairs.

Copy link

kics-logo

KICS version: v1.7.12

Category Results
HIGH HIGH 0
MEDIUM MEDIUM 0
LOW LOW 1
INFO INFO 0
TRACE TRACE 0
TOTAL TOTAL 1
Metric Values
Files scanned placeholder 1
Files parsed placeholder 1
Files failed to scan placeholder 0
Total executed queries placeholder 49
Queries failed to execute placeholder 0
Execution time placeholder 1

secrets/alibaba.go Fixed Show fixed Hide fixed
secrets/alibaba.go Dismissed Show dismissed Hide dismissed
@baruchiro baruchiro changed the title validate pairs of secrets feat: validate pairs of secrets Feb 20, 2024
@baruchiro baruchiro requested a review from jossef February 20, 2024 09:12
@baruchiro baruchiro marked this pull request as ready for review February 20, 2024 09:13
@baruchiro baruchiro merged commit 0c6fcaa into master Feb 21, 2024
8 checks passed
@baruchiro baruchiro deleted the baruchiro/Add-Secret-validation branch February 21, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant