Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reduce false positives by hashicorp #6

Merged
merged 4 commits into from
Mar 28, 2024
Merged

fix: reduce false positives by hashicorp #6

merged 4 commits into from
Mar 28, 2024

Conversation

baruchiro
Copy link

Description:

To add this rule I took examples from the official Hashicorp documentation, but now I used this rule and it find too generic cases such as const TagPassword = "password".

Using the Entropy field is a balance between true/false positives, since with 3.5 it will ignore almost all passwords less then 10 characters length.

Checklist:

  • Does your PR pass tests?
  • Have you written new tests for your changes?
  • Have you lint your code locally prior to submission?

Original: gitleaks#1358

@baruchiro baruchiro merged commit aea43c0 into master Mar 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant