Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make code Python 3.8+ compatible and bump version to 0.0.3 #4

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

jherbel
Copy link
Collaborator

@jherbel jherbel commented Jul 25, 2024

The | operator in type hints was introduced in 3.10, so we use
typing.Optional instead.

Also run tests for all Python version >=3.8.

@jherbel jherbel force-pushed the dev/joerg/fix_python_version branch 3 times, most recently from 14d64f8 to efb01ad Compare July 29, 2024 07:39
@jherbel jherbel changed the title Set mininum Python version to 3.10 and bump version to 0.0.3 Make code Python 3.8+ compatible and bump version to 0.0.3 Jul 29, 2024
The `|` operator in type hints was introduced in 3.10, so we use
`typing.Optional` instead.

Also run tests for all Python version >=3.8.
@jherbel jherbel force-pushed the dev/joerg/fix_python_version branch from efb01ad to 4db7b2d Compare July 29, 2024 07:47
@jherbel jherbel requested a review from racicLuka July 29, 2024 07:50
@jherbel jherbel merged commit aa3f89f into main Jul 29, 2024
12 checks passed
@jherbel jherbel deleted the dev/joerg/fix_python_version branch July 29, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants