refactor: remove lodash #1949
Closed
refactor: remove lodash #1949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace lodash with native ES2015 functions (#1871) Co-authored-by: Jo Liss <[email protected]>
bd82
commented
Jun 30, 2023
| import { tokenStructuredMatcher } from "../../scan/tokens" | ||
|
|
||
| // ES2019 Array.prototype.flatMap | ||
| function flatMap<U, R>(arr: U[], callback: (x: U, idx: number) => R[]): R[] { |
There was a problem hiding this comment.
TODO: extract to utils / functional-utils file
There was a problem hiding this comment.
Or maybe change the compilation target to ES2019?
However, compilation target changes should be done in a separate PR, so the extraction to utils should still be done...
bd82
force-pushed
the
remove_lodash_new
branch
2 times, most recently
from
3c721fb to
fbfeab6
Compare
|
Seems like a ~6% performance regression in the JSON lexer benchmark. |
|
Dropping this, will evaluate remda instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.