Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHIA-1730: chia plotnft CLI improvements #18833

Draft
wants to merge 32 commits into
base: main
Choose a base branch
from
Draft

CHIA-1730: chia plotnft CLI improvements #18833

wants to merge 32 commits into from

Conversation

emlowe
Copy link
Contributor

@emlowe emlowe commented Nov 7, 2024

Some experiments with making plotnft eassier to use

@emlowe emlowe added the Changed Required label for PR that categorizes merge commit message as "Changed" for changelog label Nov 7, 2024
Copy link

coveralls-official bot commented Nov 7, 2024

Pull Request Test Coverage Report for Build 11826430502

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 409 of 414 (98.79%) changed or added relevant lines in 4 files are covered.
  • 231 unchanged lines in 16 files lost coverage.
  • Overall coverage increased (+0.2%) to 91.137%

Changes Missing Coverage Covered Lines Changed/Added Lines %
chia/cmds/plotnft_funcs.py 65 70 92.86%
Files with Coverage Reduction New Missed Lines %
chia/daemon/keychain_proxy.py 1 74.58%
chia/cmds/plotnft.py 1 98.85%
chia/farmer/farmer.py 1 73.0%
chia/wallet/wallet_node.py 1 87.96%
chia/plotters/madmax.py 1 50.6%
chia/timelord/timelord_launcher.py 2 89.29%
chia/server/node_discovery.py 4 81.1%
chia/daemon/server.py 7 83.24%
chia/cmds/start_funcs.py 10 66.3%
chia/full_node/full_node.py 10 86.08%
Totals Coverage Status
Change from base Build 11804208692: 0.2%
Covered Lines: 103408
Relevant Lines: 113241

💛 - Coveralls

Comment on lines 197 to 224
help="Change the payout instructions for a pool. To get the launcher id, use plotnft show.",
"Set the name of a plotnft",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this help change intentional?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, looks like a typo

@emlowe emlowe changed the title chia plotnft CLI improvements CHIA-1730: chia plotnft CLI improvements Nov 8, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the merge_conflict Branch has conflicts that prevent merge to main label Nov 12, 2024
@github-actions github-actions bot removed the merge_conflict Branch has conflicts that prevent merge to main label Nov 12, 2024
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

Copy link
Contributor

File Coverage Missing Lines
chia/cmds/plotnft_funcs.py 92.9% lines 220, 233, 305, 322, 407
Total Missing Coverage
414 lines 5 lines 98%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog coverage-diff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants