Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean overflow blocks moved to unfinished block cache on reset chain #19106

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

almogdepaz
Copy link
Contributor

Purpose:

clean redundant blocks from overflow cache

Current Behavior:

when we call reset_chain we reset the unfinished block cache moving relevant blocks that can be infused from the overflow cache to the unfinished cache, we dont remove the overflow blocks we moved from the overflow cache creating redundant duplication

New Behavior:

remove the blocks that where moved to the unfinished block cache

Testing Notes:

@almogdepaz almogdepaz added timelord Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog labels Jan 6, 2025
@almogdepaz almogdepaz marked this pull request as ready for review January 6, 2025 14:36
@almogdepaz almogdepaz requested a review from a team as a code owner January 6, 2025 14:36
@almogdepaz almogdepaz requested a review from fchirica January 6, 2025 14:36
chia/timelord/timelord.py Outdated Show resolved Hide resolved
arvidn
arvidn previously approved these changes Jan 6, 2025
Copy link

coveralls-official bot commented Jan 6, 2025

Pull Request Test Coverage Report for Build 12649464787

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 2 of 3 (66.67%) changed or added relevant lines in 1 file are covered.
  • 188 unchanged lines in 10 files lost coverage.
  • Overall coverage increased (+0.01%) to 91.537%

Changes Missing Coverage Covered Lines Changed/Added Lines %
chia/timelord/timelord.py 2 3 66.67%
Files with Coverage Reduction New Missed Lines %
chia/timelord/timelord.py 1 79.91%
chia/full_node/pending_tx_cache.py 1 96.55%
chia/daemon/client.py 1 74.72%
chia/plotters/plotters.py 1 90.94%
chia/wallet/wallet_node.py 2 88.25%
chia/timelord/timelord_launcher.py 2 89.29%
chia/plotters/madmax.py 6 44.58%
chia/server/node_discovery.py 9 79.85%
chia/consensus/blockchain.py 26 94.42%
chia/full_node/full_node.py 139 85.96%
Totals Coverage Status
Change from base Build 12601248762: 0.01%
Covered Lines: 105325
Relevant Lines: 114883

💛 - Coveralls

fchirica
fchirica previously approved these changes Jan 7, 2025
@almogdepaz almogdepaz dismissed stale reviews from fchirica and arvidn via 9595624 January 7, 2025 10:10
Copy link
Contributor

github-actions bot commented Jan 7, 2025

File Coverage Missing Lines
chia/timelord/timelord.py 33.3% lines 344-345
Total Missing Coverage
3 lines 2 lines 33%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
coverage-diff Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog timelord
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants