CHIA-1106: Add Python bindings to chiavdf and chiapos #675
+271
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rigidity
changed the title
arvidn
reviewed
Aug 21, 2024
| } else { | ||
| None | ||
| } | ||
| } |
There was a problem hiding this comment.
I think it would be good to have a few test cases for this rust function, a few valid ones and a few invalid ones. Maybe some edge cases
| info.number_of_iterations, | ||
| proof.witness_type as u64, | ||
| ) | ||
| } |
There was a problem hiding this comment.
A few tests would be good here too. At least covering both sides of this condition if proof.witness_type + 1 > constants.max_vdf_witness_size
Rigidity
force-pushed
the
consensus-bindings
branch
2 times, most recently
from
a894a94
to
4ccb8f5
Compare
Rigidity
force-pushed
the
consensus-bindings
branch
from
7079b68
to
068bb44
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There aren't any tests for this on the chia_rs side currently, but in chia-blockchain test_blockchain.py is passing.