Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ArgumentValue.TryCoerceValue helper #7113

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

tobias-tengler
Copy link
Collaborator

No description provided.

Copy link

github-actions bot commented May 22, 2024

Qodana for .NET

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

@tobias-tengler tobias-tengler added the 👓 ready-for-review The PR is ready for review. label May 22, 2024
Copy link

codecov bot commented May 24, 2024

Codecov Report

Attention: Patch coverage is 4.16667% with 23 lines in your changes missing coverage. Please review.

Project coverage is 72.52%. Comparing base (4223f76) to head (6010da6).
Report is 1 commits behind head on main.

Files Patch % Lines
...e/src/Execution/Internal/ArgumentCoercionHelper.cs 0.00% 16 Missing ⚠️
...src/Execution/Processing/MiddlewareContext.Pure.cs 25.00% 3 Missing ⚠️
...c/Execution/Processing/MiddlewareContext.Global.cs 0.00% 2 Missing ⚠️
...sions/ProjectionObjectFieldDescriptorExtensions.cs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7113      +/-   ##
==========================================
- Coverage   76.11%   72.52%   -3.59%     
==========================================
  Files        2474     2772     +298     
  Lines      122769   138441   +15672     
==========================================
+ Hits        93442   100405    +6963     
- Misses      29327    38036    +8709     
Flag Coverage Δ
unittests 72.52% <4.16%> (-3.59%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tobias-tengler tobias-tengler force-pushed the tte/argument-value-coercion-helper branch from a816bb7 to 6010da6 Compare August 7, 2024 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant