Add record struct support for sort

[zyofeng]

Summary of the changes (Less than 80 chars)

Add support for record struct sortconvention

[PascalSenn]

@zyofeng I dont think this works as this would also treat structs like Guid as a sortable input object. Does it work when you just manually register the SortInputType?

[zyofeng]

You are correct, I've updated the PR to filter out structs such as guid, decimal by checking for PrintMembers method, which is a generated method specifically for record structs

[PascalSenn]

@zyofeng How does one of you sort queries look like?

[zyofeng]

I have the following record struct

public record struct CountryDto(string Name, string? Iso, string State, bool IsNonCompliantCountry);

using the updated sortconvention I am able to sort using this query

query {
  countries(order: [{ name: ASC }, { isNonCompliantCountry: DESC }]) {
    isNonCompliantCountry
    iso
    name
    state
  }
}

and generate the following EF Core query

SELECT [c].[IsNonCompliantCountry], [c].[Iso], [c].[Name], [c].[State]
FROM [Countries] AS [c]
ORDER BY [c].[Name], [c].[IsNonCompliantCountry] DESC

since IsNonCompliantCountry is a boolean struct this means the modified SortConvention works for normal struct.

[zyofeng]

Is this looking okay?

[michaelstaib]

This one needs tests for this otherwise we cannot verify if this is a good idea or not. We need tests showing that Guid and other important structs are ignored. What is with typed id structs ... they are not primitives.

[michaelstaib]

@zyofeng Are you still working on this?

[zyofeng]

@zyofeng Are you still working on this?

Im happy to take a look at implementing some tests for record struct vs common struct types like guid, datetime etc when I get some time, hopefully this weekend.

[zyofeng]

I've added some tests for common struct types as well as custom sort type convention, let me know if this is sufficient.