Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Omitted requireOneSlicingArgument if not set in listSize directive #7418

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

glen-84
Copy link
Collaborator

@glen-84 glen-84 commented Sep 2, 2024

Summary of the changes (Less than 80 chars)

  • Omitted requireOneSlicingArgument if not set in listSize directive.

Closes #7398


Copy link

codecov bot commented Sep 2, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 77.87%. Comparing base (3fd69ab) to head (26e889b).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...alysis/src/CostAnalysis/Types/ListSizeAttribute.cs 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7418      +/-   ##
==========================================
+ Coverage   77.82%   77.87%   +0.04%     
==========================================
  Files        2827     2827              
  Lines      141949   141953       +4     
==========================================
+ Hits       110478   110546      +68     
+ Misses      31471    31407      -64     
Flag Coverage Δ
unittests 77.87% <88.88%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glen-84 glen-84 marked this pull request as draft September 4, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Omit requireOneSlicingArgument from @listSize if false
1 participant