Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Included tag directive in Apollo Federation import list #7421

Merged
merged 5 commits into from
Sep 30, 2024

Conversation

glen-84
Copy link
Collaborator

@glen-84 glen-84 commented Sep 2, 2024

Summary of the changes (Less than 80 chars)

  • Included tag directive in Apollo Federation import list.

Closes #7413


@michaelstaib This is roughly what we discussed, but it's probably not correct, since I assume that it should only be included when the tag directive is used in the schema? If so, is there an easy way to check that?

Copy link

codecov bot commented Sep 2, 2024

Codecov Report

Attention: Patch coverage is 93.75000% with 1 line in your changes missing coverage. Please review.

Project coverage is 77.95%. Comparing base (256dd07) to head (a2f1e87).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
.../src/ApolloFederation/FederationTypeInterceptor.cs 93.75% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7421   +/-   ##
=======================================
  Coverage   77.95%   77.95%           
=======================================
  Files        2836     2836           
  Lines      142551   142562   +11     
=======================================
+ Hits       111129   111139   +10     
- Misses      31422    31423    +1     
Flag Coverage Δ
unittests 77.95% <93.75%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michaelstaib michaelstaib self-assigned this Sep 24, 2024
@michaelstaib michaelstaib marked this pull request as ready for review September 29, 2024 20:40
@michaelstaib michaelstaib merged commit d8b055a into main Sep 30, 2024
5 checks passed
@michaelstaib michaelstaib deleted the gai/issue-7413 branch September 30, 2024 20:31
michaelstaib pushed a commit that referenced this pull request Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@tag Directive Not Generated in Import Array
2 participants