Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added header to disabling null bubbling #7429

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tobias-tengler
Copy link
Collaborator

@tobias-tengler tobias-tengler commented Sep 4, 2024

TODO:

  • We need to check with the Relay team how it's supposed to be implemented.

Copy link

codecov bot commented Sep 4, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 8 lines in your changes missing coverage. Please review.

Project coverage is 76.39%. Comparing base (b87ec6a) to head (0f61372).

Files with missing lines Patch % Lines
...re/src/AspNetCore/DefaultHttpRequestInterceptor.cs 25.00% 3 Missing ⚠️
.../src/AspNetCore/DefaultSocketSessionInterceptor.cs 25.00% 3 Missing ⚠️
...src/AspNetCore/Extensions/HttpContextExtensions.cs 75.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7429      +/-   ##
==========================================
- Coverage   78.48%   76.39%   -2.09%     
==========================================
  Files        2447     2811     +364     
  Lines      120428   141054   +20626     
==========================================
+ Hits        94515   107762   +13247     
- Misses      25913    33292    +7379     
Flag Coverage Δ
unittests 76.39% <50.00%> (-2.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant