Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Used CookieCrumble in more test projects #7461

Merged
merged 4 commits into from
Sep 24, 2024
Merged

Conversation

glen-84
Copy link
Collaborator

@glen-84 glen-84 commented Sep 14, 2024

Summary of the changes (Less than 80 chars)

  • Used CookieCrumble in more test projects.

@michaelstaib @PascalSenn – There are two remaining test projects using Snapshooter:

  • CodeGeneration.CSharp.Tests
  • CodeGeneration.Razor.Tests

Removing the Snapshot.FullName(); usage here is difficult, as the test helpers do some funky stuff with paths.

Could you please assist with this? It's currently not possible to set a custom path for the snapshot. TBH, the snapshots should probably not be written to .cs files outside of a snapshot directory (as it adds to compilation overhead).

Notes:

  • The directory name __mismatch__ is now used everywhere (instead of a mix of that and __MISMATCH__).
  • I removed the TryTest stuff from RedisOperationDocumentStorageTests. I'm not sure what purpose it served, and 2 of the tests relied on Snapshot.FullName(); because of it.

Copy link

codecov bot commented Sep 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.86%. Comparing base (688e71f) to head (648cc64).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7461      +/-   ##
==========================================
- Coverage   77.86%   77.86%   -0.01%     
==========================================
  Files        2826     2826              
  Lines      141958   141958              
==========================================
- Hits       110541   110530      -11     
- Misses      31417    31428      +11     
Flag Coverage Δ
unittests 77.86% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michaelstaib michaelstaib marked this pull request as ready for review September 24, 2024 09:10
@glen-84 glen-84 changed the title Removed ChilliCream.Testing.Utilities and Snapshooter.Xunit Used CookieCrumble in more test projects Sep 24, 2024
@michaelstaib michaelstaib merged commit 475049b into main Sep 24, 2024
102 checks passed
@michaelstaib michaelstaib deleted the gai/remove-snapshooter branch September 24, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants