Only cache authorization policies if permitted by policy provider #7705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobias-tengler
force-pushed
the
tte/only-cache-policies-if-permitted-by-policyprovider
branch
from
5ff7efc
to
dab3d9f
Compare
michaelstaib
approved these changes
Nov 9, 2024
michaelstaib
deleted the
tte/only-cache-policies-if-permitted-by-policyprovider
branch
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7705 +/- ##
=======================================
Coverage 73.93% 73.93%
=======================================
Files 2917 2917
Lines 151097 151116 +19
Branches 17556 17560 +4
=======================================
+ Hits 111716 111732 +16
- Misses 33527 33529 +2
- Partials 5854 5855 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Authorization policies should only be cached if the
AllowsCachingPoliciesproperty on theIAuthorizationPolicyProvideris set totrue.The policies will stay cached for the vast majority of Hot Chocolate users, since the property is
truefor theDefaultAuthorizationPolicyProvider, but developers choosing to implement a customIAuthorizationPolicyProvidernow have control over the caching behavior and Hot Chocolate is once again aligned to regular ASP.NET Core ;)Fixes #7704