Skip to content

Commit

Permalink
Update CoreML model versions in GitHub Actions workflow and setup script
Browse files Browse the repository at this point in the history
This commit updates the CoreML model references in the GitHub Actions workflow and the setup script to the latest versions (v1.15.1) from the KataGo GitHub repository.

**Changes include:**

1. **GitHub Actions Workflow Updates:**
   - Replaced the model URLs for FP16 and FP32 models in multiple steps to use the new version `v1.15.1-coreml2`:
     - **FP16 Model**: Updated from `KataGoModel19x19fp16v14s7709731328.mlpackage.zip` to `KataGoModel19x19fp16v14s9996604416.mlpackage.zip`.
     - **FP32 Model**: Updated from `KataGoModel19x19fp32v14s7709731328.mlpackage.zip` to `KataGoModel19x19fp32v14s9996604416.mlpackage.zip`.
     - **FP32 Meta Model**: Updated from `KataGoModel19x19fp32meta1.mlpackage.zip` to `KataGoModel19x19fp32v15m1humanv0.mlpackage.zip`.
   - Ensured symbolic links point to the updated model names.

2. **Setup Script Updates:**
   - Updated the model download command for FP16 in the setup script to reflect the new version `KataGoModel19x19fp16v14s9996604416.mlpackage.zip`.
   - Added commands to download and setup the new FP32 model version `KataGoModel19x19fp32v15m1humanv0.mlpackage.zip`.
   - Adjusted the unzip command and file renaming for consistency with new model names.

**Impact:**
These changes ensure that the workflow and setup scripts use the latest models, which may include performance improvements and updates. This is crucial for maintaining compatibility and leveraging the latest features provided by the KataGo models.

**Note:**
The old model versions have been phased out from the scripts, and the new versions maintain the existing symbolic link structure for seamless integration in the build process.
  • Loading branch information
ChinChangYang committed Jul 27, 2024
1 parent 6be8e7a commit f88412d
Show file tree
Hide file tree
Showing 2 changed files with 30 additions and 29 deletions.
42 changes: 21 additions & 21 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,25 +40,25 @@ jobs:
run: |
mkdir -p models
cd models
wget https://github.com/ChinChangYang/KataGo/releases/download/v1.13.2-coreml1/KataGoModel19x19fp16v14s7709731328.mlpackage.zip
unzip KataGoModel19x19fp16v14s7709731328.mlpackage.zip
ln -s ../../../../../../models/KataGoModel19x19fp16v14s7709731328.mlpackage ../cpp/xcode/DerivedData/Build/Products/Debug/KataGoModel19x19fp16.mlpackage
wget https://github.com/ChinChangYang/KataGo/releases/download/v1.15.1-coreml2/KataGoModel19x19fp16v14s9996604416.mlpackage.zip
unzip KataGoModel19x19fp16v14s9996604416.mlpackage.zip
ln -s ../../../../../../models/KataGoModel19x19fp16v14s9996604416.mlpackage ../cpp/xcode/DerivedData/Build/Products/Debug/KataGoModel19x19fp16.mlpackage
- name: Setup CoreML model FP32
run: |
mkdir -p models
cd models
wget https://github.com/ChinChangYang/KataGo/releases/download/v1.13.2-coreml1/KataGoModel19x19fp32v14s7709731328.mlpackage.zip
unzip KataGoModel19x19fp32v14s7709731328.mlpackage.zip
ln -s ../../../../../../models/KataGoModel19x19fp32v14s7709731328.mlpackage ../cpp/xcode/DerivedData/Build/Products/Debug/KataGoModel19x19fp32.mlpackage
wget https://github.com/ChinChangYang/KataGo/releases/download/v1.15.1-coreml2/KataGoModel19x19fp32v14s9996604416.mlpackage.zip
unzip KataGoModel19x19fp32v14s9996604416.mlpackage.zip
ln -s ../../../../../../models/KataGoModel19x19fp32v14s9996604416.mlpackage ../cpp/xcode/DerivedData/Build/Products/Debug/KataGoModel19x19fp32.mlpackage
- name: Setup CoreML model FP32 meta
run: |
mkdir -p models
cd models
wget https://github.com/ChinChangYang/KataGo/releases/download/v1.15.1-coreml1/KataGoModel19x19fp32meta1.mlpackage.zip
unzip KataGoModel19x19fp32meta1.mlpackage.zip
ln -s ../../../../../../models/KataGoModel19x19fp32meta1.mlpackage ../cpp/xcode/DerivedData/Build/Products/Debug/KataGoModel19x19fp32meta1.mlpackage
wget https://github.com/ChinChangYang/KataGo/releases/download/v1.15.1-coreml2/KataGoModel19x19fp32v15m1humanv0.mlpackage.zip
unzip KataGoModel19x19fp32v15m1humanv0.mlpackage.zip
ln -s ../../../../../../models/KataGoModel19x19fp32v15m1humanv0.mlpackage ../cpp/xcode/DerivedData/Build/Products/Debug/KataGoModel19x19fp32m1.mlpackage
- name: Setup test data
run: |
Expand Down Expand Up @@ -145,17 +145,17 @@ jobs:
run: |
mkdir -p models
cd models
wget https://github.com/ChinChangYang/KataGo/releases/download/v1.13.2-coreml1/KataGoModel19x19fp16v14s7709731328.mlpackage.zip
unzip KataGoModel19x19fp16v14s7709731328.mlpackage.zip
ln -s ../../models/KataGoModel19x19fp16v14s7709731328.mlpackage ../cpp/build/KataGoModel19x19fp16.mlpackage
wget https://github.com/ChinChangYang/KataGo/releases/download/v1.15.1-coreml2/KataGoModel19x19fp16v14s9996604416.mlpackage.zip
unzip KataGoModel19x19fp16v14s9996604416.mlpackage.zip
ln -s ../../models/KataGoModel19x19fp16v14s9996604416.mlpackage ../cpp/build/KataGoModel19x19fp16.mlpackage
- name: Setup CoreML model FP32
run: |
mkdir -p models
cd models
wget https://github.com/ChinChangYang/KataGo/releases/download/v1.13.2-coreml1/KataGoModel19x19fp32v14s7709731328.mlpackage.zip
unzip KataGoModel19x19fp32v14s7709731328.mlpackage.zip
ln -s ../../models/KataGoModel19x19fp32v14s7709731328.mlpackage ../cpp/build/KataGoModel19x19fp32.mlpackage
wget https://github.com/ChinChangYang/KataGo/releases/download/v1.15.1-coreml2/KataGoModel19x19fp32v14s9996604416.mlpackage.zip
unzip KataGoModel19x19fp32v14s9996604416.mlpackage.zip
ln -s ../../models/KataGoModel19x19fp32v14s9996604416.mlpackage ../cpp/build/KataGoModel19x19fp32.mlpackage
- name: Run KataGo GPU error test with CoreML backend
run: |
Expand All @@ -166,17 +166,17 @@ jobs:
run: |
mkdir -p models
cd models
wget https://github.com/ChinChangYang/KataGo/releases/download/v1.15.1-coreml1/KataGoModel19x19fp16meta1.mlpackage.zip
unzip KataGoModel19x19fp16meta1.mlpackage.zip
ln -s ../../models/KataGoModel19x19fp16meta1.mlpackage ../cpp/build/KataGoModel19x19fp16meta1.mlpackage
wget https://github.com/ChinChangYang/KataGo/releases/download/v1.15.1-coreml2/KataGoModel19x19fp16v15m1humanv0.mlpackage.zip
unzip KataGoModel19x19fp16v15m1humanv0.mlpackage.zip
ln -s ../../models/KataGoModel19x19fp16v15m1humanv0.mlpackage ../cpp/build/KataGoModel19x19fp16m1.mlpackage
- name: Setup CoreML model FP32 of human SL network
run: |
mkdir -p models
cd models
wget https://github.com/ChinChangYang/KataGo/releases/download/v1.15.1-coreml1/KataGoModel19x19fp32meta1.mlpackage.zip
unzip KataGoModel19x19fp32meta1.mlpackage.zip
ln -s ../../models/KataGoModel19x19fp32meta1.mlpackage ../cpp/build/KataGoModel19x19fp32meta1.mlpackage
wget https://github.com/ChinChangYang/KataGo/releases/download/v1.15.1-coreml2/KataGoModel19x19fp32v15m1humanv0.mlpackage.zip
unzip KataGoModel19x19fp32v15m1humanv0.mlpackage.zip
ln -s ../../models/KataGoModel19x19fp32v15m1humanv0.mlpackage ../cpp/build/KataGoModel19x19fp32m1.mlpackage
- name: Run KataGo GPU error test of human SL network with CoreML backend
run: |
Expand Down
17 changes: 9 additions & 8 deletions cpp/xcode/setup.sh
Original file line number Diff line number Diff line change
Expand Up @@ -3,15 +3,16 @@ wget https://github.com/ChinChangYang/KataGo/releases/download/v1.13.2-coreml1/k
mv kata1-b18c384nbt-s7709731328-d3715293823.bin.gz DerivedData/KataGo/Build/Products/Debug/model.bin.gz
wget https://github.com/lightvector/KataGo/releases/download/v1.4.5/g170-b40c256x2-s5095420928-d1229425124.bin.gz
mv g170-b40c256x2-s5095420928-d1229425124.bin.gz DerivedData/KataGo/Build/Products/Debug/modelv8.bin.gz
wget https://github.com/ChinChangYang/KataGo/releases/download/v1.13.2-coreml1/KataGoModel19x19fp16v14s7709731328.mlpackage.zip
mv KataGoModel19x19fp16v14s7709731328.mlpackage.zip DerivedData/KataGo/Build/Products/Debug/
wget https://github.com/ChinChangYang/KataGo/releases/download/v1.15.1-coreml2/KataGoModel19x19fp16v14s9996604416.mlpackage.zip
mv KataGoModel19x19fp16v14s9996604416.mlpackage.zip DerivedData/KataGo/Build/Products/Debug/
rm -rf DerivedData/KataGo/Build/Products/Debug/KataGoModel19x19fp16.mlpackage
unzip DerivedData/KataGo/Build/Products/Debug/KataGoModel19x19fp16v14s7709731328.mlpackage.zip -d DerivedData/KataGo/Build/Products/Debug/
mv DerivedData/KataGo/Build/Products/Debug/KataGoModel19x19fp16v14s7709731328.mlpackage DerivedData/KataGo/Build/Products/Debug/KataGoModel19x19fp16.mlpackage
wget https://github.com/ChinChangYang/KataGo/releases/download/v1.15.1-coreml1/KataGoModel19x19fp32meta1.mlpackage.zip
mv KataGoModel19x19fp32meta1.mlpackage.zip DerivedData/KataGo/Build/Products/Debug/
rm -rf DerivedData/KataGo/Build/Products/Debug/KataGoModel19x19fp32meta1.mlpackage
unzip DerivedData/KataGo/Build/Products/Debug/KataGoModel19x19fp32meta1.mlpackage.zip -d DerivedData/KataGo/Build/Products/Debug/
unzip DerivedData/KataGo/Build/Products/Debug/KataGoModel19x19fp16v14s9996604416.mlpackage.zip -d DerivedData/KataGo/Build/Products/Debug/
mv DerivedData/KataGo/Build/Products/Debug/KataGoModel19x19fp16v14s9996604416.mlpackage DerivedData/KataGo/Build/Products/Debug/KataGoModel19x19fp16.mlpackage
wget https://github.com/ChinChangYang/KataGo/releases/download/v1.15.1-coreml2/KataGoModel19x19fp32v15m1humanv0.mlpackage.zip
mv KataGoModel19x19fp32v15m1humanv0.mlpackage.zip DerivedData/KataGo/Build/Products/Debug/
rm -rf DerivedData/KataGo/Build/Products/Debug/KataGoModel19x19fp32v15m1humanv0.mlpackage
unzip DerivedData/KataGo/Build/Products/Debug/KataGoModel19x19fp32v15m1humanv0.mlpackage.zip -d DerivedData/KataGo/Build/Products/Debug/
mv DerivedData/KataGo/Build/Products/Debug/KataGoModel19x19fp32v15m1humanv0.mlpackage DerivedData/KataGo/Build/Products/Debug/KataGoModel19x19fp32m1.mlpackage
ln -s ../../../../../../configs/misc/coreml_example.cfg DerivedData/KataGo/Build/Products/Debug/gtp.cfg
ln -s ../../../../../../configs/misc/metal_gtp.cfg DerivedData/KataGo/Build/Products/Debug/metal_gtp.cfg
ln -s ../../../../../../tests DerivedData/KataGo/Build/Products/Debug/tests
Expand Down

0 comments on commit f88412d

Please sign in to comment.