Skip to content

Commit

Permalink
Fix disabling placeholder didn't disable extracting potential placeho…
Browse files Browse the repository at this point in the history
…lder from `<select>` options.
  • Loading branch information
Xon committed Aug 6, 2024
1 parent 0a0687d commit 937cdcb
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion src/scripts/choices.ts
Original file line number Diff line number Diff line change
@@ -285,7 +285,8 @@ class Choices implements ChoicesInterface {
classNames: this.config.classNames,
template: (data: ChoiceFull): HTMLOptionElement =>
this._templates.option(data),
extractPlaceholder: !this._hasNonChoicePlaceholder,
extractPlaceholder:
this.config.placeholder && !this._hasNonChoicePlaceholder,
});
}

0 comments on commit 937cdcb

Please sign in to comment.