Skip to content

Commit

Permalink
Just give-up on binary caching as it causes issues
Browse files Browse the repository at this point in the history
  • Loading branch information
Xon committed Aug 21, 2024
1 parent a210cc1 commit ef3f39f
Showing 1 changed file with 3 additions and 24 deletions.
27 changes: 3 additions & 24 deletions .github/workflows/browsers.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,34 +27,10 @@ jobs:
run: npm ci --no-audit
env:
HUSKY_SKIP_INSTALL: true
PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1

# https://github.com/microsoft/playwright/issues/7249#issuecomment-2301568516
# - name: Detect Playwright version (Windows)
# if: runner.os == 'windows'
# run: echo "PLAYWRIGHT_VERSION=$(npm ll -p --depth=0 playwright | grep -o '@.*')" | Out-File -FilePath $env:GITHUB_ENV -Append
- name: Detect Playwright version (Linux and Mac)
if: runner.os != 'windows'
run: echo "PLAYWRIGHT_VERSION=$(npm ll -p --depth=0 playwright | grep -o '@.*')" >> $GITHUB_ENV
- name: Put $HOME in env
if: runner.os == 'windows'
run: echo "HOME=$HOME" | Out-File -FilePath $env:GITHUB_ENV -Append

- name: Cache playwright binaries
uses: actions/cache@v4
id: playwright-cache
with:
# see https://playwright.dev/docs/browsers#managing-browser-binaries
path: ${{ runner.os == 'Windows' && format('{0}{1}', env.HOME, '\AppData\Local\ms-playwright') || runner.os == 'Linux' && '~/.cache/ms-playwright' || '~/Library/Caches/ms-playwright' }}
key: ${{ runner.os }}-playwright-${{ env.PLAYWRIGHT_VERSION }}
restore-keys: |
${{ runner.os }}-playwright-

- name: Install Playwright Browsers
run: npx playwright install --with-deps
if: steps.playwright-cache.outputs.cache-hit != 'true'
- run: npx playwright install-deps
if: steps.playwright-cache.outputs.cache-hit != 'true'

- name: Run Playwright tests
run: npx playwright test --project=${{ matrix.browser }}
Expand All @@ -78,6 +54,9 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
with:
fetch-depth: 1

- uses: actions/setup-node@v4
with:
node-version: 20
Expand Down

0 comments on commit ef3f39f

Please sign in to comment.