Code

Draft: Large item count performance#1170

Code

Merged

Xon merged 46 commits intoChoices-js:mainChoices-js/Choices:mainfrom Xon:large-item-count-performanceXon/Choices.js:large-item-count-performanceCopy head branch name to clipboardAug 27, 2024

+3,693-3,624

Commits

Commits on Aug 25, 2024

• Reduce work done for unhighlightAll during on-click handler (batch handler in v11.0.0-rc8 would also have helped) Choices-js#522 Choices-js#599

  Xon

  committed
  6cb9667

  Copy full SHA for 6cb9667

• Performance tests with thousands of items selected

  Xon

  committed
  26c843a

  Copy full SHA for 26c843a

• Inline highlightItem/unhighlightItem to avoid quadratic complexity

  Xon

  committed
  491652b

  Copy full SHA for 491652b

• Switch from string literal type to effectively valueOf<EventType> to intern strings

  Xon

  committed
  9f9eed4

  Copy full SHA for 9f9eed4

• Update tests to permit newer target versions (main source tree still targets ES5)

  Xon

  committed
  8a66486

  Copy full SHA for 8a66486

• Fix fragile highlightall/unhighlightall tests

  Xon

  committed
  4468603

  Copy full SHA for 4468603

• Dramatically reduce the performance impact of changing items (avoid re-rendering all items on every change)

  Xon

  committed
  0e7789e

  Copy full SHA for 0e7789e

• Support item rendering latching onto pre-rendered items

  Xon

  committed
  89537aa

  Copy full SHA for 89537aa

• Handle case where the element needs to be regenerated

  Xon

  committed
  f84bdc9

  Copy full SHA for f84bdc9

• Fix placeholder not applying as expected for select-one when loading items

  Xon

  committed
  e4d3f9c

  Copy full SHA for e4d3f9c

• Push highlight css toggle into reducer, simplifying state tracking

  Xon

  committed
  0d74ffc

  Copy full SHA for 0d74ffc

• Avoid touching every item after an item is added, instead call unhighlightall as required

  Xon

  committed
  a6179d8

  Copy full SHA for a6179d8

• Simplify _onBlur & _onFocus

  Xon

  committed
  60f08bb

  Copy full SHA for 60f08bb

• Adjust unhighlightAll to generally be called in a _store.withTxn to reduce redundnant rendering passes

  Xon

  committed
  4a45aba

  Copy full SHA for 4a45aba

• Hoist variables to reduce bundle size

  Xon

  committed
  298ecb7

  Copy full SHA for 298ecb7

• Preserve choices associated with groups

  Xon

  committed
  e3f085b

  Copy full SHA for e3f085b

• Inline renderChoice functionality & cleanup duplication

  Xon

  committed
  77b2811

  Copy full SHA for 77b2811

• Cache element/group to reduce rendering time

  Xon

  committed
  68bd104

  Copy full SHA for 68bd104

• Avoid reflows by using display: none; vs visibility: hidden;

  Xon

  committed
  3b857c5

  Copy full SHA for 3b857c5

• Remove overly fragile unit testing of rendering

  Xon

  committed
  3f849e1

  Copy full SHA for 3f849e1

• Restore older placeholder rendering behavior

  Xon

  committed
  44c2407

  Copy full SHA for 44c2407

• Fix dropdown flip logic did not consider verticality of both sides of the dropdown (ref: formio#2)

  Xon

  committed
  d969bde

  Copy full SHA for d969bde

• Update e2e tests

  Xon

  committed
  1f6415a

  Copy full SHA for 1f6415a

• linting fixes

  Xon

  committed
  b9d71ef

  Copy full SHA for b9d71ef

• Adjust when the choice's cached element is purged

  Xon

  committed
  99e33c9

  Copy full SHA for 99e33c9

• Simplify groupId check, and push group label rendering into template

  Xon

  committed
  a2ddd5a

  Copy full SHA for a2ddd5a

• Use Element.replaceChildren API, update polyfill definition

  Xon

  committed
  d4db913

  Copy full SHA for d4db913

• Compile JS files

  Xon

  committed
  acf08d0

  Copy full SHA for acf08d0

• Disable unusably slow test

  Xon

  committed
  e435374

  Copy full SHA for e435374

Commits on Aug 26, 2024

• Commit linter fixes

  Xon

  committed
  e784912

  Copy full SHA for e784912

Commits on Aug 27, 2024

• cleanup css

  Xon

  committed
  8b8439a

  Copy full SHA for 8b8439a

• Remove unused eslint disable

  Xon

  committed
  1dae822

  Copy full SHA for 1dae822

• Add ValueOf utility type

  Xon

  committed
  b364578

  Copy full SHA for b364578

• Use const object instead of loose constants for text/select-one/select-multiple

  Xon

  committed
  a0f42ea

  Copy full SHA for a0f42ea

• Allow renderSelectedChoices to be a direct boolean to simplify internal logic

  Xon

  committed
  c7ab134

  Copy full SHA for c7ab134

• Add e2e test for renderSelectedChoices flag

  Xon

  committed
  dfb15a7

  Copy full SHA for dfb15a7

• Invalidate cached choice when an item is added/removed & fix renderSelectedChoices === 'always' with select-multiple

  Xon

  committed
  b5b6c8e

  Copy full SHA for b5b6c8e

• Revert & add some variable hoisting as it compressed better

  Xon

  committed
  5f5a057

  Copy full SHA for 5f5a057

• Cleanup unused function and redundant variable assignment

  Xon

  committed
  f1c3170

  Copy full SHA for f1c3170

• Update tests

  Xon

  committed
  63653f0

  Copy full SHA for 63653f0

• Compile JS files

  Xon

  committed
  f6b54f7

  Copy full SHA for f6b54f7

• Cleanup unused import

  Xon

  committed
  d3028c7

  Copy full SHA for d3028c7

• Commit lint fixed file

  Xon

  committed
  9e60d6e

  Copy full SHA for 9e60d6e

• Update CHANGELOG.md

  Xon

  committed
  b6e9809

  Copy full SHA for b6e9809

• Cleanup appending group label to choices

  Xon

  committed
  6e72240

  Copy full SHA for 6e72240

• Appease linter

  Xon

  committed
  f534235

  Copy full SHA for f534235