refact: fix (almost) all shellcheck errors #691
Annotations
2 errors and 10 warnings
Run ShellCheck
reviewdog: Too many results (annotations) in diff.
You may miss some annotations due to GitHub limitation for annotation created by logging command.
Please check GitHub Actions log console to see all results.
Limitation:
- 10 warning annotations and 10 error annotations per step
- 50 annotations per job (sum of annotations from all the steps)
- 50 annotations per run (separate from the job annotations, these annotations aren't created by users)
Source: https://github.com/orgs/community/discussions/26680#discussioncomment-3252835
|
Run ShellCheck
Process completed with exit code 2.
|
Run ShellCheck:
core/tabs/system-setup/arch/server-setup.sh#L229
[shellcheck] reported by reviewdog 🐶
Prefer mapfile or read -a to split command output (or quote to avoid splitting).
Raw Output:
./core/tabs/system-setup/arch/server-setup.sh:229:14: warning: Prefer mapfile or read -a to split command output (or quote to avoid splitting). (ShellCheck.SC2207)
|
Run ShellCheck:
core/tabs/system-setup/arch/server-setup.sh#L460
[shellcheck] reported by reviewdog 🐶
Useless cat. Consider 'cmd < file | ..' or 'cmd file | ..' instead.
Raw Output:
./core/tabs/system-setup/arch/server-setup.sh:460:17: info: Useless cat. Consider 'cmd < file | ..' or 'cmd file | ..' instead. (ShellCheck.SC2002)
|
Run ShellCheck:
core/tabs/system-setup/arch/server-setup.sh#L499
[shellcheck] reported by reviewdog 🐶
nc is referenced but not assigned.
Raw Output:
./core/tabs/system-setup/arch/server-setup.sh:499:32: warning: nc is referenced but not assigned. (ShellCheck.SC2154)
|
Run ShellCheck:
core/tabs/system-setup/arch/server-setup.sh#L504
[shellcheck] reported by reviewdog 🐶
Useless cat. Consider 'cmd < file | ..' or 'cmd file | ..' instead.
Raw Output:
./core/tabs/system-setup/arch/server-setup.sh:504:17: info: Useless cat. Consider 'cmd < file | ..' or 'cmd file | ..' instead. (ShellCheck.SC2002)
|
Run ShellCheck:
core/tabs/utils/ssh.sh#L65
[shellcheck] reported by reviewdog 🐶
The surrounding quotes actually unquote this. Remove or escape them.
Raw Output:
./core/tabs/utils/ssh.sh:65:10: warning: The surrounding quotes actually unquote this. Remove or escape them. (ShellCheck.SC2027)
|
Run ShellCheck:
core/tabs/utils/ssh.sh#L65
[shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting.
Raw Output:
./core/tabs/utils/ssh.sh:65:10: info: Double quote to prevent globbing and word splitting. (ShellCheck.SC2086)
|
Run ShellCheck:
core/tabs/utils/ssh.sh#L65
[shellcheck] reported by reviewdog 🐶
Did you forget to close this double quoted string?
Raw Output:
./core/tabs/utils/ssh.sh:65:26: warning: Did you forget to close this double quoted string? (ShellCheck.SC1078)
|
Run ShellCheck:
core/tabs/utils/ssh.sh#L66
[shellcheck] reported by reviewdog 🐶
This is actually an end quote, but due to next char it looks suspect.
Raw Output:
./core/tabs/utils/ssh.sh:66:9: info: This is actually an end quote, but due to next char it looks suspect. (ShellCheck.SC1079)
|
Run ShellCheck:
core/tabs/utils/ssh.sh#L66
[shellcheck] reported by reviewdog 🐶
The surrounding quotes actually unquote this. Remove or escape them.
Raw Output:
./core/tabs/utils/ssh.sh:66:10: warning: The surrounding quotes actually unquote this. Remove or escape them. (ShellCheck.SC2027)
|
Run ShellCheck:
core/tabs/utils/ssh.sh#L66
[shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting.
Raw Output:
./core/tabs/utils/ssh.sh:66:10: info: Double quote to prevent globbing and word splitting. (ShellCheck.SC2086)
|
Loading