📃 fix: replace every ~ AND ,, for posix compliance

[adamperkowski]

Type of Change

• Bug fix
• Refactoring

Description

Using tilde is a bashism, using $HOME is not.
Same with logic expressions and ,,s.

Checklist

• My code adheres to the coding and style guidelines of the project.
• I have performed a self-review of my own code.
• My changes generate no errors/warnings/merge conflicts.

(📃 is a shell script btw)

[adamperkowski]

More to do

[adamperkowski]

@ChrisTitusTech In case you're wondering, this is OK to merge. I'll do the rest of archtitus in a later PR.

[adamperkowski]

Clearing up confusion here:

• using =~ is one heck of a bashism. can be avoided very easily
• ~/ is pretty obvious. it's an alias to $HOME. a part of GNU core utils
• "${foo,,}" =~ ^[a-z][a-z0-9_.-]{0,62}[a-z0-9]$ has like 3+ bashisms so changing it to tr '[:upper:]' '[:lower:]' is completely fine. tr is much easier to understand, too

this PR explicitly cleans up some bashisms. logic remains unchanged (excluding this below, it was only y before, I added Y)

linutil/core/tabs/system-setup/arch/server-setup.sh

Line 281 in f688f0c

if [[ "$force" == "y" || "$force" == "Y" ]]

[jeevithakannan2]

~ to $HOME is okay but the if condition changes is not necessary as whatever you do server-setup.sh will be a bash script. The arch iso ships only bash. The sh is symlinked to bash. You need to install dash package in order for this to work as posix which cannot be done. And the shebang is bash.

[adamperkowski]

~ to $HOME is okay but the if condition changes is not necessary as whatever you do server-setup.sh will be a bash script. The arch iso ships only bash. The sh is symlinked to bash. You need to install dash package in order for this to work as posix which cannot be done. And the shebang is bash.

I am 100℅ aware. But if we want to keep it fully posix compliant, let's keep it fully posix compliant.

[jeevithakannan2]

I am 100℅ aware. But if we want to keep it fully posix compliant, let's keep it fully posix compliant.

It's a waste even though you make it fully posix compliant