Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce the size of the linutil binary by removing unused features from tui/Cargo.toml #760

Closed
wants to merge 0 commits into from

Conversation

zdiff
Copy link
Contributor

@zdiff zdiff commented Oct 5, 2024

Type of Change

  • New feature
  • Bug fix
  • Documentation update
  • Refactoring
  • Hotfix
  • Security patch
  • UI/UX improvement

Description

Reduce the size of the linutil binary by removing unused features from tui/Cargo.toml

Before PR

$ cargo build --release && ls -l target/release/linutil
    Finished `release` profile [optimized] target(s) in 0.41s
-rwx------ 2 zdiff zdiff 4266856 Oct  5 01:24 target/release/linutil

After PR

$ cargo build --release && ls -l target/release/linutil
    Finished `release` profile [optimized] target(s) in 0.08s
-rwx------ 2 zdiff zdiff 4160360 Oct  5 01:35 target/release/linutil

Testing

Build and ran linutil using cargo build --release && ./target/release/linutil

Impact

Reduction in binary size

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no errors/warnings/merge conflicts.

Copy link
Collaborator

@adamperkowski adamperkowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@zdiff zdiff changed the title Reduce the size of the linutil binary by removing unused features from core/Cargo.toml and tui/Cargo.toml Reduce the size of the linutil binary by removing unused features from tui/Cargo.toml Oct 5, 2024
Copy link
Contributor

@cartercanedy cartercanedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, good work

@adamperkowski adamperkowski added the rust Pull requests that update Rust code label Oct 25, 2024
@zdiff zdiff closed this Nov 6, 2024
@adamperkowski
Copy link
Collaborator

adamperkowski commented Nov 6, 2024

what happened?

EDIT: nvm #922

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rust Pull requests that update Rust code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants