feat: btrfs assistant & grub-btrfs #789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds fedora-btrfs-assistant.sh, updates tab_data and documentation.
…into FedoraBTRFS
also some more enhancements and wording improvements.
reinstall snapper action removed because removing and reinstalling snapper is a very unlikely action. and also snapper can't handle ./snapsots folder in the disk after reinstalling: "creating btrfs subvolume .snapshots failed since it already exists".
home snapshot taken first because it's config can be saved to first root snapshot.
Co-authored-by: Adam Perkowski <[email protected]>
Co-authored-by: Adam Perkowski <[email protected]>
Co-authored-by: Adam Perkowski <[email protected]>
Co-authored-by: Adam Perkowski <[email protected]>
Co-authored-by: Adam Perkowski <[email protected]>
Co-authored-by: Adam Perkowski <[email protected]>
Co-authored-by: Adam Perkowski <[email protected]>
Co-authored-by: Adam Perkowski <[email protected]>
Co-authored-by: Adam Perkowski <[email protected]>
Co-authored-by: Nyx <[email protected]>
Co-authored-by: Nyx <[email protected]>
Co-authored-by: Adam Perkowski <[email protected]>
Co-authored-by: Adam Perkowski <[email protected]>
…into FedoraBTRFS
|
Re-opened PR with docgen updated. Thanks for useful tool @adamperkowski |
adamperkowski
approved these changes
Oct 9, 2024
There was a problem hiding this comment.
Re-opened PR with docgen updated. Thanks for useful tool @adamperkowski
Thanks. Was merged in #784.
adamperkowski
changed the title
ChrisTitusTech
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
I added a script under Fedora section to installs Btrfs Assistant with snapper and Grub-Btrfs to Fedora, allowing snapshots to be displayed in the Grub menu.
Additionally, it configures scheduled timeline snapshots for both the root and home directories, ensures automatic GRUB updates following snapshot creation, and includes a DNF plugin that facilitates automatic snapshots before/after package installations.
Because of default Fedora disk partitioning during OS installation, the /boot configured as an separate EXT4 partition in Fedora. Therefore, it cannot be included in root snapshots.
Necessary information has been provided in the documentation, description and post install steps for users to pay attention to this point.
Fedora's EXT4 /boot, btrfs root(/) choice also prevents restoring Timeshift backups. So snapper still seems to be the best solution for Fedora anyway.
The grub-btrfs installation was left optional because it is a deeper system intervention and some systems have problems with snapshot booting due to the “tpm.c:150:unknown TPM error” error. This seems like a common problem even with unmodified Fedora systems... https://bugzilla.redhat.com/show_bug.cgi?id=2128485
A mitigation step was also provided for those who encountered the error.
Testing
Impact
Users often want to use the btrfs snapshot feature, but guides on the internet seems too complicated because they start from partitioning steps from initial setup. I tried to perform the snapshot process in the easiest way without interfering with the partitioning.
As long as /boot is not corrupted, Fedora users can recover their systems with these tools. They may need to evaluate manual backup options for /boot.
Issues / other PRs related
Additional Information
Checklist