Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed Dissortion #741

Merged
merged 2 commits into from
Aug 10, 2024
Merged

Removed Dissortion #741

merged 2 commits into from
Aug 10, 2024

Conversation

sailaja-adapa
Copy link
Contributor

@sailaja-adapa sailaja-adapa commented Aug 9, 2024

Hello Project Admin
I Removed Dissortion in Footer - Solved #711
Kindly go through this PR @ayush-t02

bb

@sailaja-adapa
Copy link
Contributor Author

Kindly go through this PR @ayush-t02

@ayush-t02
Copy link
Collaborator

what exactly has been done here?

@ayush-t02
Copy link
Collaborator

I feel a lot of info is present in the footer. best approach would be to restyle the footer to handle all the links and info, preferably multi-line footer

@sailaja-adapa
Copy link
Contributor Author

I am sorry @ayush-t02 it is my first time contributing to open source so I thought I should remove the overlapping between chrome gaming and other social links and I thought I should give good padding between footer links

@sailaja-adapa
Copy link
Contributor Author

Can you explain me briefly what should I need to do? @ayush-t02

@ayush-t02
Copy link
Collaborator

@sailaja-adapa hey sailaja no need to be sorry, we are all learning here and that is the entire point of GSSoC. all I said above is that the footer looks shabby as of now so you should try to change the design to make it look less congested but since today is the last day of contribution I'll merge this PR.

but do continue to pursue open-source.

@ayush-t02 ayush-t02 merged commit 6025589 into ChromeGaming:main Aug 10, 2024
@sailaja-adapa
Copy link
Contributor Author

Yeah okk Thank you @ayush-t02

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants