switch to more stable survival function

Ciela-Institute · May 31, 2024 · 30f33a1 · 30f33a1
1 parent 8f29f83
commit 30f33a1
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/pqm/pqm.py b/src/pqm/pqm.py
@@ -135,7 +135,7 @@ def pqm_chi2(
     chi2_stat, _, dof, _ = _pqm_test(x_samples, y_samples, num_refs, whiten)
     if dof != num_refs - 1:
         # Rescale chi2 to new value which has the same cumulative probability
-        cp = chi2.cdf(chi2_stat, dof, scale=chi2_stat)
-        chi2_stat = chi2.ppf(cp, num_refs - 1, scale=chi2_stat)
+        cp = chi2.sf(chi2_stat, dof)
+        chi2_stat = chi2.isf(cp, num_refs - 1)
         dof = num_refs - 1
     return chi2_stat, dof
diff --git a/tests/test_gaussian.py b/tests/test_gaussian.py
@@ -43,4 +43,4 @@ def test_fail_chi2():
 
         new.append(pqm_chi2(x_samples, y_samples, num_refs=100))
     new = np.array(new)
-    assert np.mean(new[:, 0]) / 99 > 10
+    assert np.mean(new[:, 0]) / 99 > 2