Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(registry): add support to artifact registry #75

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

joaomlopes
Copy link
Contributor

Bump gcp-cli and gcp-gcr Orbs to support the extra new parameter repository when wanting to push the image to GCP Artifact Registry instead of Container Registry

Bump gcp-cli and gcp-gcr Orbs to support the extra new parameter `repository` when wanting to push the image to GCP Artifact Registry instead of Container Registry
@joaomlopes joaomlopes requested a review from a team as a code owner October 14, 2024 14:17
@david-montano-circleci
Copy link

Hello @joaomlopes . This looks good. I just want to check if we can run tests for this so let me see what I can do.
Thank you for your contributions!

@joaomlopes
Copy link
Contributor Author

Hello @joaomlopes . This looks good. I just want to check if we can run tests for this so let me see what I can do. Thank you for your contributions!

Of course! Let me know if you need anything else from me on this! I appreciate you taking the time!

@david-montano-circleci
Copy link

@joaomlopes I fixed the pipeline of this orb. Can you make a small commit to see if the pipelines can correctly report the CircleCI result back?
I already tested this and it looks ok.

@joaomlopes
Copy link
Contributor Author

@joaomlopes I fixed the pipeline of this orb. Can you make a small commit to see if the pipelines can correctly report the CircleCI result back? I already tested this and it looks ok.

@david-montano-circleci Definitely! I just removed an extra line on one of the files! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants