Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warning deleting profile picture#4767 #5046

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Warning deleting profile picture#4767 #5046

wants to merge 3 commits into from

Conversation

Deeppjp116
Copy link

Fixes #4767

Description of the Changes

  • Enhanced Remove Picture Functionality: Updated the profile picture removal process to improve user experience by addressing the following:
    • Immediate Removal: Clicking the 'Remove Picture' button now immediately removes the profile picture.
    • Confirmation Dialog: Added a confirmation dialog that prompts the user to confirm their action before the picture is removed. This prevents accidental removals and ensures that users are aware of the change.

Default state

defult-state

After delete

picutre_detele-state

here is the video

new-issue4767.mp4

Note: Please check if you would like us to assist in the PR.

codeclimate[bot]
codeclimate bot reviewed Aug 18, 2024
View reviewed changes
app/controllers/users/circuitverse_controller.rb Outdated
@@ -46,7 +46,7 @@ def groups

def profile_params
params.require(:user).permit(:name, :profile_picture, :country, :educational_institute,
:subscribed, :locale, :remove_picture, :avatar, :vuesim)
:subscribed, :locale, :remove_picture, :avatar, :vuesim)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Align the arguments of a method call if they span more than one line.

spec/requests/api/v1/users_controller/update_spec.rb
@@ -85,6 +85,10 @@
params: { remove_picture: "1" },
headers: { Authorization: "Token #{token}" }, as: :json
end

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing whitespace detected.

@codeclimate CodeClimate
Copy link

codeclimate bot commented Aug 20, 2024

Code Climate has analyzed commit cefa808 and detected 2 issues on this pull request.

Here's the issue category breakdown:

Category Count
Style 2

View more on Code Climate.

@Deeppjp116 Deeppjp116 marked this pull request as ready for review August 20, 2024 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeclimate codeclimate[bot] codeclimate[bot] left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: Warning message after deleting profile picture
1 participant
@Deeppjp116