forked from excid3/simple_discussion
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(gsoc'24): adding language filter to avoid inappropriate language #24
Merged
tachyons
merged 11 commits into
CircuitVerse:master
from
Waishnav:adding-language-filter
Jul 25, 2024
Merged
feat(gsoc'24): adding language filter to avoid inappropriate language #24
tachyons
merged 11 commits into
CircuitVerse:master
from
Waishnav:adding-language-filter
Jul 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UI changes includes following - instead of too many boxes i.e borders on the all thread page, with the help of just right side border to side panel. it is much more readable - previously link of the thread was title now, I improved it to have thread card as link since there was no other clickable items in the card - in the forum_post template, now meta data of forum post like post author and edit, delete action buttons are now visually separated from the post using just background color
Waishnav
force-pushed
the
adding-language-filter
branch
from
July 7, 2024 15:31
3c64f97
to
ba26daa
Compare
…r` gem - these filters are applied on forum_thread's title, forum_posts's body - error messages are now improves with proper altert message styling using bootstrap's alter class
Waishnav
force-pushed
the
adding-language-filter
branch
from
July 7, 2024 15:37
ba26daa
to
7e28ad3
Compare
Good job,
SimpleDiscussion.setup do |config|
config.send_email_notifications = false # Default: true
config.send_slack_notifications = false # Default: true
config.profanity_filter = false # Default: true
end |
I added similar test like this in |
Waishnav
force-pushed
the
adding-language-filter
branch
2 times, most recently
from
July 21, 2024 10:15
1e5e626
to
cd90ad6
Compare
Waishnav
force-pushed
the
adding-language-filter
branch
from
July 21, 2024 10:17
cd90ad6
to
ebabb57
Compare
tachyons
requested changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17
This PR covers the functionality for letting user know they can use inappropriate language in Forum threads and forum posts. For reference see screenshot below.