Clam 2586 save urls html #1281
Merged
Clam 2586 save urls html #1281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ragusaa
force-pushed
the
CLAM-2586-SaveUrlsHTML
branch
from
638344d
to
73a2786
Compare
Kangie
reviewed
Jun 25, 2024
ragusaa
force-pushed
the
CLAM-2586-SaveUrlsHTML
branch
3 times, most recently
from
685401d
to
44832fc
Compare
ragusaa
force-pushed
the
CLAM-2586-SaveUrlsHTML
branch
4 times, most recently
from
7243032
to
5ea9ec7
Compare
micahsnyder
requested changes
Jul 18, 2024
ragusaa
force-pushed
the
CLAM-2586-SaveUrlsHTML
branch
2 times, most recently
from
d6705c7
to
113412e
Compare
micahsnyder
requested changes
Jul 18, 2024
ragusaa
force-pushed
the
CLAM-2586-SaveUrlsHTML
branch
from
f8c043a
to
2c9abc4
Compare
micahsnyder
reviewed
Jul 19, 2024
ragusaa
force-pushed
the
CLAM-2586-SaveUrlsHTML
branch
from
eba2c5d
to
44aa119
Compare
micahsnyder
previously approved these changes
Jul 19, 2024
Store URLs found in HTML `<a>` and `<form>` tags during scan of HTML files when recording scan metadata. HTML URL recording will be ON by default, but is a part of the generate-metadata-json feature. The generate-metadata-json feature is OFF by default. This introduces a new general scan option: - libclamav: `CL_SCAN_GENERAL_STORE_HTML_URLS`. - ClamD: `JsonStoreHTMLUrls`. - ClamScan: `--json-store-html-urls` Thank you Matt Jolly for the helpful comment on the pull request.
micahsnyder
force-pushed
the
CLAM-2586-SaveUrlsHTML
branch
from
44aa119
to
666e047
Compare
|
Rebased and removed the temporary function from the TODO. Ready to test and hopefully merge. |
micahsnyder
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.