fix: Attempt to create log file if it does not exist. #1322

userwiths · 2024-07-29T14:25:54Z

Fixes: #1155
It might seem a bit messy but the gist of the PR is that.

We introduce fc_upsert_logg_file method, which attempts to create the directories & log file as required.
We move the drop_privileges case/branch later during the execution. If we do this before we fc_upsert_logg_file our log file, then we can't use root privileges even if freshclam is started as root.
In order to chown the directories (and file, overkill?) we introduce the field dbOwner in the fc_config structure.

Seems this has been handled in documentation as a step of the setup.

…ile we want a file.

libfreshclam/libfreshclam.c

userwiths · 2024-09-09T07:15:48Z

@micahsnyder tagging you cause this might have been forgotten. Managed to get the CI all green and put it in review. Just a reminder.

userwiths added 5 commits July 29, 2024 13:18

fix: Fix failure to start when log file is missing.

12a516c

Escape after the last slash, otherwise a directory will be created wh…

76a31a2

…ile we want a file.

fix: Allow folder creation as root and give access to clamav.

c6c8d1f

revert changes done during testing.

eee3949

return removed empty line.

aa3480d

github-advanced-security bot found potential problems Jul 29, 2024

View reviewed changes

libfreshclam/libfreshclam.c Fixed Show fixed Hide fixed

ref: Formating and cleanup

4815aef

userwiths marked this pull request as ready for review August 15, 2024 06:04

github-advanced-security bot found potential problems Aug 15, 2024

View reviewed changes

libfreshclam/libfreshclam.c Fixed Show fixed Hide fixed

userwiths added 4 commits August 30, 2024 10:55

Use cli_safer_strdup and cli_strtok instead of the vanila functions.

94f1871

Handle case where log file is not set.

e8ba5b2

Do not attempt chmod on windows.

35e0ffd

Fix windows build due to getpwuid and getpwname functions

7c7c9d6

micahsnyder self-requested a review September 9, 2024 15:56

Provide feedback