-
Notifications
You must be signed in to change notification settings - Fork 706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clamscan systemd service and timer #928
Open
nils-werner
wants to merge
5
commits into
Cisco-Talos:main
Choose a base branch
from
nils-werner:clamscan-timers
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+95
−2
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
7ffbf10
clamscan systemd unit and timer
nils-werner 7a260e2
Clamdscan service and timer
nils-werner d64f619
clamav-clamscan remove unneeded systemd params
nils-werner d9e5c46
Use %f instead of %I because were dealing with paths
nils-werner 6eb69cc
Reduce CPU load for clamdscan, just to be safe
nils-werner File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -47,3 +47,24 @@ if(WIN32) | |
else() | ||
install(TARGETS clamdscan DESTINATION ${CMAKE_INSTALL_BINDIR} COMPONENT programs) | ||
endif() | ||
|
||
if(SYSTEMD_FOUND) | ||
configure_file( | ||
${CMAKE_CURRENT_SOURCE_DIR}/[email protected] | ||
${CMAKE_CURRENT_BINARY_DIR}/[email protected] @ONLY) | ||
configure_file( | ||
${CMAKE_CURRENT_SOURCE_DIR}/[email protected] | ||
${CMAKE_CURRENT_BINARY_DIR}/[email protected] @ONLY) | ||
install( | ||
FILES ${CMAKE_CURRENT_BINARY_DIR}/[email protected] | ||
DESTINATION ${SYSTEMD_UNIT_DIR} COMPONENT programs) | ||
install( | ||
FILES ${CMAKE_CURRENT_BINARY_DIR}/[email protected] | ||
DESTINATION ${SYSTEMD_USER_UNIT_DIR} COMPONENT programs) | ||
install( | ||
FILES ${CMAKE_CURRENT_BINARY_DIR}/[email protected] | ||
DESTINATION ${SYSTEMD_UNIT_DIR} COMPONENT programs) | ||
install( | ||
FILES ${CMAKE_CURRENT_BINARY_DIR}/[email protected] | ||
DESTINATION ${SYSTEMD_USER_UNIT_DIR} COMPONENT programs) | ||
endif() |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
[Unit] | ||
Description=ClamAV clamdscan %f | ||
Documentation=man:clamdscan(1) man:clamdscan.conf(5) https://docs.clamav.net/ | ||
|
||
[Service] | ||
Nice=19 | ||
IOSchedulingClass=idle | ||
ExecStart=@prefix@/bin/clamdscan --infected --multiscan --fdpass %f |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
[Unit] | ||
Description=Weekly ClamAV clamdscan %f | ||
|
||
[Timer] | ||
OnCalendar=weekly | ||
AccuracySec=1h | ||
RandomizedDelaySec=1h | ||
Persistent=true | ||
|
||
[Install] | ||
WantedBy=timers.target |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -46,3 +46,24 @@ if(WIN32) | |
else() | ||
install(TARGETS clamscan DESTINATION ${CMAKE_INSTALL_BINDIR} COMPONENT programs) | ||
endif() | ||
|
||
if(SYSTEMD_FOUND) | ||
configure_file( | ||
${CMAKE_CURRENT_SOURCE_DIR}/[email protected] | ||
${CMAKE_CURRENT_BINARY_DIR}/[email protected] @ONLY) | ||
configure_file( | ||
${CMAKE_CURRENT_SOURCE_DIR}/[email protected] | ||
${CMAKE_CURRENT_BINARY_DIR}/[email protected] @ONLY) | ||
install( | ||
FILES ${CMAKE_CURRENT_BINARY_DIR}/[email protected] | ||
DESTINATION ${SYSTEMD_UNIT_DIR} COMPONENT programs) | ||
install( | ||
FILES ${CMAKE_CURRENT_BINARY_DIR}/[email protected] | ||
DESTINATION ${SYSTEMD_USER_UNIT_DIR} COMPONENT programs) | ||
install( | ||
FILES ${CMAKE_CURRENT_BINARY_DIR}/[email protected] | ||
DESTINATION ${SYSTEMD_UNIT_DIR} COMPONENT programs) | ||
install( | ||
FILES ${CMAKE_CURRENT_BINARY_DIR}/[email protected] | ||
DESTINATION ${SYSTEMD_USER_UNIT_DIR} COMPONENT programs) | ||
endif() |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
[Unit] | ||
Description=ClamAV clamscan %f | ||
Documentation=man:clamscan(1) man:clamscan.conf(5) https://docs.clamav.net/ | ||
|
||
[Service] | ||
Nice=19 | ||
IOSchedulingClass=idle | ||
ExecStart=@prefix@/bin/clamscan --recursive=yes --infected --suppress-ok-results %f |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
[Unit] | ||
Description=Weekly ClamAV clamscan %f | ||
|
||
[Timer] | ||
OnCalendar=weekly | ||
AccuracySec=1h | ||
RandomizedDelaySec=1h | ||
Persistent=true | ||
|
||
[Install] | ||
WantedBy=timers.target |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It may also be nice to have the main CMakeList.txt summary print out this variable next to the other one:
clamav/CMakeLists.txt
Line 1256 in 90a9fbd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nils-werner I think we forgot about this.