Clam-2379 Correction to PE wwunpack overread guard #977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code looks good, verifying the test case and will approve. |
ragusaa
approved these changes
Jul 27, 2023
The prior fix for the wwunpack overread in commit 89cd0df was a little too late, but also removed an earlier, smaller guard for a write. This commit just moves the larger guard a little earlier to protect against both. Resolves: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=60655
micahsnyder
force-pushed
the
CLAM-2379-wwunpack-guard-correction
branch
from
e1685b1
to
566119a
Compare
|
Just rebased so the fuzz-regression build will work correctly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The prior fix for the wwunpack overread in commit
89cd0df was a little too late, but also removed an earlier, smaller guard for a write.
This commit just moves the larger guard a little earlier to protect against both.
Resolves: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=60655
Note: This bug never made it into a release, so not a vuln.