Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clam 2410 recent coverity issues #998

Merged
merged 8 commits into from
Aug 17, 2023
Merged

Clam 2410 recent coverity issues #998

merged 8 commits into from
Aug 17, 2023

Commits on Aug 17, 2023

  1. Coverity-514958: Error handling check with getpagesize call 

    `cli_getpagesize()` may return -1 in an error condition.
If it does, let's just treat it as 4096.

I believe the actual coverity complaint is a false positive, but it's
fair to account for the error case and this should shut it up.
    @micahsnyder
    micahsnyder committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    994aca4 View commit details
    Browse the repository at this point in the history

  2. Coverity-415957, 415950: ClamDTOP error handling 

    On error `getmaxyx()` may set the output params to -1.
We must check for this before treating the result as unsigned.
    @micahsnyder
    micahsnyder committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    ed0667f View commit details
    Browse the repository at this point in the history

  3. Coverity-415956: Fix Y2K38 datetime truncation issue in CVD headers

    @micahsnyder
    micahsnyder committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    252ea16 View commit details
    Browse the repository at this point in the history

  4. Coverity-415955: Fix Y2K38 issue with clambc --info datetime

    @micahsnyder
    micahsnyder committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    cc6e2b2 View commit details
    Browse the repository at this point in the history

  5. Coverity-415954: Remove duplicated/dead code

    @micahsnyder
    micahsnyder committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    e034271 View commit details
    Browse the repository at this point in the history

  6. Coverity-415953: Ensure string NULL-terminated in clamonacc init 

    The `read()` function doesn't null terminate the `nwatch_str`, but
`strtol` requires it to be NULL-terminated.
    @micahsnyder
    micahsnyder committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    16aa3f8 View commit details
    Browse the repository at this point in the history

  7. Coverity-415952: Remove logically dead code 

    In aspack decrypt function, there's a check to make sure that backbytes
doesn't exceed 57, because it is used as an index in init_array.
However, it is mathematically impossible.
So this commit removes the check.
    @micahsnyder
    micahsnyder committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    bcca829 View commit details
    Browse the repository at this point in the history

  8. Freshclam: Minor error handling improvement 

    Somehow forgot to save and commit final error handling check on the new
set_tls_client_certificate() function.
This change is needed to have Freshclam fail if you try to use the new
client certificate environment variables incorrectly.
    @micahsnyder
    micahsnyder committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    9581ed6 View commit details
    Browse the repository at this point in the history