Using exec to launch consul-template, in order to take PID 1. #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@eesprit I've checked your changes locally (with updates towards master) and it looks ok. @stevendborrelli This change looks ok. |
|
@eesprit @stevendborrelli Change is present in master so there's no need for this PR anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tiny modification makes consul-template takes PID 1 over the initial bash process, which allow a better signal management (docker stop/kill will be forwarded to consul-template wich will andle it nicely and stop the "runner" - aka haproxy).
Without this, the docker stop signal (SIGTERM) is not forwarded to consul-template by bash, and the process is killed (SIGKILL) by docker after 10 seconds (default timeout), which is not really clean.