Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to disable query-target/rsp-subtree/rsp-prop-include in GET r… #102

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vmatveyevGit
Copy link

In apic and nxos/aci connectors GET request has query-target/rsp-subtree/rsp-prop-include parameters always added to url.
This does not work for some api requests - for example /mqapi2/deployment.query.json?mode=getvmmCapInfo - that api fails with addition of those parameters.
Changed the code, to give calling function ability to disable those parameters in get, but providing empty values for them, like it is done for other parameters.
Default values for those parameters are non-empty, so it does not change anything for existing scripts.
Also made left stripping "/" in the dn, as that api also fails with "//" in the url - as one "/" is already provided by connect function and another "/" may be present in the dn. This makes apic and nxos connectors consistent with handling dn parameter with and without leading "/".

Copy link
Contributor

@GerriorL GerriorL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your submission! Could you please add in a changelog?

@vmatveyevGit
Copy link
Author

Thanks for your submission! Could you please add in a changelog

Not sure how to add changelog - please see git log output below and let me know what else need to be done.
Please see the change in the commit itself.

Thanks,
Vladimir

[vmatveye@vmatveye-bld2 rest]$ git log
commit 066807c
Author: Vladimir Matveyev [email protected]
Date: Fri Feb 17 17:22:21 2023 -0800

Ability to disable query-target/rsp-subtree/rsp-prop-include in GET request

commit 2967649

@GerriorL
Copy link
Contributor

I've made a note of this and will add the changelog on our side. That's a clear enough commit message that it shouldn't be an issue

@GerriorL GerriorL self-requested a review March 10, 2023 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants