generated new imcsdk and updated mo, meta and respected files #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
"make test" |
vvb
reviewed
Nov 29, 2024
| from ..connection.info import custom_setup, custom_teardown | ||
|
|
||
|
|
||
| def setup_module(): |
There was a problem hiding this comment.
setup_module and teardown_module must not be used in this test.
Everything under tests/unit_tests is expected to work without a connection to an actual server.
If any of your tests need the handle.login(), then you need to move them out of unit_tests
There was a problem hiding this comment.
sure vikrant, i will update the code
vvb
reviewed
Nov 29, 2024
tests/unit_tests/test_ipmi.py
Outdated
| @@ -11,7 +11,11 @@ | |||
| # See the License for the specific language governing permissions and | |||
| # limitations under the License. | |||
|
|
|||
| from mock import patch, MagicMock | |||
| try: | |||
There was a problem hiding this comment.
if unittest.mock provides the same functionality, then let us use that and remove the from mock import patch, MagicMock all together. No need to do try and except.
There was a problem hiding this comment.
it's already removed vikrant, now i don changes only for "test_imcversion.py"
vvb
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.