Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PyPI upload workflow uses trusted publisher instead of PyPI API token #26

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

rafa-be
Copy link
Collaborator

@rafa-be rafa-be commented Oct 1, 2024

Uses trusted PyPI publisher credentials instead of PyPI API token when releasing the package.

@JamieSlome Please go to the "Publishing" tab from PyPI dashboard for Scaler and add Github as a trusted publisher, with the following values:

  • Owner: Citi
  • Repository name: scaler
  • Workflow name: pypi.yml
  • Environment name: release

I couldn't test it, as I didn't have access to the PyPI package anymore.

@JamieSlome JamieSlome changed the title PyPI upload workflow uses thrusted publisher instead of PyPI API token. PyPI upload workflow uses thrusted publisher instead of PyPI API token Oct 1, 2024
Copy link
Member

@JamieSlome JamieSlome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@JamieSlome JamieSlome changed the title PyPI upload workflow uses thrusted publisher instead of PyPI API token PyPI upload workflow uses trusted publisher instead of PyPI API token Oct 1, 2024
@JamieSlome JamieSlome merged commit ec0e2db into Citi:main Oct 2, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants