Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v2 progress bar #212

Merged
merged 6 commits into from
May 2, 2024
Merged

v2 progress bar #212

merged 6 commits into from
May 2, 2024

Conversation

maxatdetroit
Copy link
Member

Part of #201, #202, #205

This PR updates progress bar to:

  • Simplify names of attributes
  • Convert label to a slotted element (instead of attribute-defined content)
  • Use boolean attributes micro-syntax where possible

Note: this PR also removes support for multi-bar feature but that work is meant to stay in #211. I removed the code here as well to preempt merge conflicts.

@maxatdetroit maxatdetroit added enhancement New feature or request cleanup labels Apr 30, 2024
@maxatdetroit maxatdetroit self-assigned this Apr 30, 2024
@maxatdetroit maxatdetroit changed the base branch from dev to 2.0.0-alpha1 April 30, 2024 19:44
@maxatdetroit maxatdetroit merged commit 88ea3dd into 2.0.0-alpha1 May 2, 2024
1 check passed
@maxatdetroit maxatdetroit deleted the progress.v2 branch May 2, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jedgar1mx jedgar1mx jedgar1mx approved these changes

Assignees

@maxatdetroit maxatdetroit

Labels
cleanup enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maxatdetroit @jedgar1mx