Clean-up.Spinner #219
Merged
Clean-up.Spinner #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxatdetroit
approved these changes
May 28, 2024
src/stories/spinner.stories.js
Outdated
Comment on lines
36
to
38
| } else { | ||
| delete spinner.size; | ||
| } |
There was a problem hiding this comment.
This shouldn't be necessary because the size attribute will never have been set if we reach this else condition.
There was a problem hiding this comment.
Removing this else statement entirely should continue to work as expected.
src/stories/spinner.stories.js
Outdated
Comment on lines
41
to
43
| } else { | ||
| delete spinner.displayType; | ||
| } |
There was a problem hiding this comment.
Similar comment regarding unnecessary delete statement.
Open
maxatdetroit
requested changes
Jul 31, 2024
maxatdetroit
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes data prefix and omits unused attributes as mentioned in issue #201 and #202