*: use official neo-go release with --relative-path support
#6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
OSX job fails because of nspcc-dev/neo-go#3238 |
Reverted to manual building to temporarily resolve this. They're going to resolve it but in the |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4 introduced the CI workflow which build a custom neo-go node to bypass the wallet path limitation reported in this issue. At the time it was unclear when an official version would be released with a fix, so I made an intermediate fix to not block us. Now that an official version is released that includes the required fix we can just download and include that.
Changes in this PR
download-nodescript to work when executed from a terminal.