CU-86dtu92vq - Include how to test smart contract events using boa test constructor #1268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meevee98
suggested changes
Jun 19, 2024
docs/source/testing-and-debugging.md
Outdated
Comment on lines
144
to
147
| example, we are testing the "Transfer" event, so we can use the `Nep17TransferEvent` class from `boaconstructor`. If you | ||
| plan to test other events, it's best you also create a class or method that will help you unwrap the stack results. | ||
| Check out [`Nep17TransferEvent`](https://github.com/CityOfZion/boa-test-constructor/blob/20a45755767b3d919bf7a594cfff6bff78cb72ac/boaconstructor/__init__.py#L302-L314) | ||
| implementation for reference. |
There was a problem hiding this comment.
Regarding creating new classes to handle other events, I think it's better to give an example in this file than to just link to the boaconstructor code.
Can you change it to create a class to handle the same Nep17 event? But include a validation for from or to being None (doesn't need to explain)
meevee98
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.